-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to add subchecks #19
Conversation
Do I understand https://docs.brevis.one/current/en/Content/Functionality/Status%20Functions/Monitor%20the%20SMS%20Gateway.htm correctly in that, that the |
I don't understand it either. The API docs say "Specifies how much internal memory is occupied (bytes)", would be nice to see how much is left instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that one thing, I think that's good to go.
merge when ready |
To implement this feature in #17 I had to refactor some of the code. Mainly there's now a bit more parsing of the
check.php
endpoint happening.Also the output logic now works with multiple "sub-checks" and outputs to determine the final exit code.
Example:
A
--debug
flag was introduced to return the fullcheck.php
endpoint output.Fixes #17